Don't switch to CF's active document for frames or iframes....

Don't switch to CF's active document for frames or iframes.This fixes an issue where a page that uses CF would be loaded in an IFRAME on Google Images.Instead of attempting to load CF (not supported), we now defer to the host browser.  Previously a blank page was displayed.TEST=Run new unit tests: FullTabModeIE_SubIFrame and FullTabModeIE_SubFrameBUG=22989
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30782

[amit, 2009-11-02 23:36:25]

very nice. LGTM with a few nits.

http://codereview.chromium.org/343086/diff/1/2
File chrome_frame/protocol_sink_wrap.cc (right):

http://codereview.chromium.org/343086/diff/1/2#newcode639
Line 639: ScopedComPtr<IHTMLWindow2> win, parent;
nit: Rename win -> current_frame, parent -> parent_frame?

http://codereview.chromium.org/343086/diff/1/8
File chrome_frame/test/data/full_tab_sub_frame1.html (right):

http://codereview.chromium.org/343086/diff/1/8#newcode12
Line 12: var is_chrome = /chrome/.test(navigator.userAgent.toLowerCase());
chrome_frame_tester_helpers.js has TestIfRunningInChrome() that can be used
here, maybe with some refactoring.

http://codereview.chromium.org/343086/diff/1/5
File chrome_frame/test/data/full_tab_sub_iframe_main.html (right):

http://codereview.chromium.org/343086/diff/1/5#newcode10
Line 10: <a href="http://images.google.com/imghp?hl=en">
we should avoid references to external sites, might pose issues on borg etc.

[tommi (sloooow) - chröme, 2009-11-02 23:56:36]

http://codereview.chromium.org/343086/diff/1/2
File chrome_frame/protocol_sink_wrap.cc (right):

http://codereview.chromium.org/343086/diff/1/2#newcode639
Line 639: ScopedComPtr<IHTMLWindow2> win, parent;
On 2009/11/02 23:36:25, amit wrote:
> nit: Rename win -> current_frame, parent -> parent_frame?

Done.

http://codereview.chromium.org/343086/diff/1/8
File chrome_frame/test/data/full_tab_sub_frame1.html (right):

http://codereview.chromium.org/343086/diff/1/8#newcode12
Line 12: var is_chrome = /chrome/.test(navigator.userAgent.toLowerCase());
On 2009/11/02 23:36:25, amit wrote:
> chrome_frame_tester_helpers.js has TestIfRunningInChrome() that can be used
> here, maybe with some refactoring.

Done.

http://codereview.chromium.org/343086/diff/1/5
File chrome_frame/test/data/full_tab_sub_iframe_main.html (right):

http://codereview.chromium.org/343086/diff/1/5#newcode10
Line 10: <a href="http://images.google.com/imghp?hl=en">
On 2009/11/02 23:36:25, amit wrote:
> we should avoid references to external sites, might pose issues on borg etc.

Done.