Fix a problem in the implementation of search-vs.-go-in-context-menus. We we...

Fix a problem in the implementation of search-vs.-go-in-context-menus.  We were eliding the text before passing it to the classifier, resulting in wrong destination URLs for elided strings.

This also eliminates a couple string conversions and shortens the EscapeAmpersand() algorithm.

BUG=1978
TEST=Highlight a long string in a page.  Right-click it.  Verify the string is elided in the context menu.  Click the search entry.  Verify the string you searched for is not elided.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30745

[Nico, 2009-11-02 20:39:03]

LG

http://codereview.chromium.org/343081/diff/3001/3002
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/343081/diff/3001/3002#newcode208
Line 208: params_.selection_text, std::wstring(), &is_search,
You probably still need a UTF16ToWide() here.

http://codereview.chromium.org/343081/diff/3001/3002#newcode218
Line 218: printable_selection_text.insert(++i, 1, '&');
Nice! I'd keep this in a separate function though, then you could remove the
comment. (But your call.)

[Nico, 2009-11-02 22:29:16]

tfarina: FYI