DevTools: support cross-navigation instrumentation.

DevTools: support cross-navigation instrumentation.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30713

[pfeldman, 2009-11-01 14:45:24]

Few things I changed wrt your change:
- Sniff on callback in inject_dispatch (not on direct call)
- Use plain vector of 'features' instead of the struct. The thing is that since
we need to push state from glue by means glue interfaces, the state struct must
be public. I plan to introduce constants with public feature names such as APU.
So far hard-coded.

Will soon compile and run. How do you like it?

[Kelly Norton, 2009-11-01 17:06:36]

Yes, I like this. I can see why it is favorable to just move them around as
strings for now. And most of the issues I was having concerned trying to figure
out how to organize the dependencies on the Settings struct.


On 2009/11/01 14:45:24, pfeldman wrote:
> Few things I changed wrt your change:
> - Sniff on callback in inject_dispatch (not on direct call)
> - Use plain vector of 'features' instead of the struct. The thing is that
since
> we need to push state from glue by means glue interfaces, the state struct
must
> be public. I plan to introduce constants with public feature names such as
APU.
> So far hard-coded.
> 
> Will soon compile and run. How do you like it?

[yurys, 2009-11-02 17:22:36]

LGTM, would be nice to have one source with the constants.

http://codereview.chromium.org/343075/diff/4001/5007
File chrome/browser/debugger/devtools_manager.cc (right):

http://codereview.chromium.org/343075/diff/4001/5007#newcode144
Line 144: std::pair<RenderViewHost*, std::set<std::string> >
value(inspected_rvh, std::set<std::string>());
long line

http://codereview.chromium.org/343075/diff/4001/5004
File webkit/glue/webdevtoolsagent_impl.cc (right):

http://codereview.chromium.org/343075/diff/4001/5004#newcode86
Line 86: static const char kApuAgentFeatureName[] = "apu-agent";
what source this constand should be kept in sync with?

http://codereview.chromium.org/343075/diff/4001/5004#newcode87
Line 87: // Keep these in sync with the ones in inject_dispatch.js.
style: blank line above the comment

[pfeldman, 2009-11-02 17:29:44]

http://codereview.chromium.org/343075/diff/4001/5007
File chrome/browser/debugger/devtools_manager.cc (right):

http://codereview.chromium.org/343075/diff/4001/5007#newcode144
Line 144: std::pair<RenderViewHost*, std::set<std::string> >
value(inspected_rvh, std::set<std::string>());
On 2009/11/02 17:22:36, Yury Semikhatsky wrote:
> long line

Done.

http://codereview.chromium.org/343075/diff/4001/5004
File webkit/glue/webdevtoolsagent_impl.cc (right):

http://codereview.chromium.org/343075/diff/4001/5004#newcode86
Line 86: static const char kApuAgentFeatureName[] = "apu-agent";
On 2009/11/02 17:22:36, Yury Semikhatsky wrote:
> what source this constand should be kept in sync with?

Done.

http://codereview.chromium.org/343075/diff/4001/5004#newcode87
Line 87: // Keep these in sync with the ones in inject_dispatch.js.
On 2009/11/02 17:22:36, Yury Semikhatsky wrote:
> style: blank line above the comment

Done.