Conditionally added pepper_test_plugin.gyp as all.gyp dependency based on whe...

Conditionally added pepper_test_plugin.gyp as all.gyp dependency based on whether enable_pepper variable is set to 1. Defaults to 0.
Added run_as block to automatically launch chrome and load the plugin when the pepper_test_plugin project is run or debugged.
See new instructions in updated README.
TEST=none
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30741

[apatrick, 2009-10-30 23:24:31]

Scratch that I see a problem...

[apatrick, 2009-10-31 00:02:43]

Ready for review now. Thanks.

[brettw, 2009-11-02 16:55:49]

http://codereview.chromium.org/343070/diff/3001/4001
File webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp (right):

http://codereview.chromium.org/343070/diff/3001/4001#newcode11
Line 11: '../../../chrome/chrome.gyp:chrome',
I think this means that whenever you build the plugin, then it will check the
dependencies of Chrome, which seems to always involve redoing some bindings and
relinking even when nothing's changed. I'm worried this will make development on
the plugin slower.

Can you think of a better way to get what you want here?

[apatrick, 2009-11-02 17:38:50]

http://codereview.chromium.org/343070/diff/3001/4001
File webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp (right):

http://codereview.chromium.org/343070/diff/3001/4001#newcode11
Line 11: '../../../chrome/chrome.gyp:chrome',
I could simply remove it as a dependency. Then you would need to be careful to
separately build Chrome if that was necessary. My reasoning was that if the
dependency check determined that some Chrome source files had changed, compiling
those files and linking Chrome is usually the right thing to do. If you only
change plugin specific source files, Chrome is not dependent on them and there
is no additional cost except some additional dependency checks. I'm willing to
to take either approach. I can see that, for example, making some trivial change
to npapi.h might not necessitate building Chrome. I'm leaning towards removing
it as a dependency now. Do you agree?

[brettw, 2009-11-02 18:01:45]

I'm OK with having to rebuild Chrome when we change the interface in some way.
Since there's so few of us developing for it, hopefully we can all remember and
it won't cause problems. If it does, we can always add it later.

In most cases, adding something new will require two-sided changes so it will be
super obvious if you forgot to build it.

[apatrick, 2009-11-02 19:19:19]

Done.