Issue 343060: Remove WebCore dependencies from accessibility_ui_element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343060: Remove WebCore dependencies from accessibility_ui_element. (Closed)

Created:
11 years, 1 month ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove WebCore dependencies from accessibility_ui_element. R=darin BUG=24596 TEST=no regressions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30617

Patch Set 1 #

Patch Set 2 : Patch v3. #

Patch Set 3 : Actually added WebAccessibilityRole. #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+373 lines, -117 lines)			Patch
M	webkit/api/public/WebAccessibilityObject.h	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download
A	webkit/api/public/WebAccessibilityRole.h	View		1 chunk	+129 lines, -0 lines	0 comments	Download
M	webkit/api/src/AssertMatchingEnums.cpp	View	1	3 chunks	+83 lines, -0 lines	0 comments	Download
M	webkit/api/src/WebAccessibilityObject.cpp	View		2 chunks	+56 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/accessibility_ui_element.cc	View	1	5 chunks	+95 lines, -115 lines	1 comment	Download
M	webkit/webkit.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 1 month ago (2009-10-30 19:37:58 UTC) #3

LGTM

http://codereview.chromium.org/343060/diff/3001/3006
File webkit/tools/test_shell/accessibility_ui_element.cc (right):

http://codereview.chromium.org/343060/diff/3001/3006#newcode12
Line 12: using WebKit::WebCString;
sort

Expand Messages | Collapse Messages