Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 343057: Add unary not operator to fast compiler. (Closed)

Created:
11 years, 1 month ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add unary not operator to fast compiler. Committed: http://code.google.com/p/v8/source/detail?r=3193

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -0 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 1 chunk +61 lines, -0 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
William Hesse
Will do other platforms
11 years, 1 month ago (2009-10-30 14:32:10 UTC) #1
William Hesse
Will do other platforms.
11 years, 1 month ago (2009-10-30 14:33:39 UTC) #2
Kevin Millikin (Chromium)
It's confusing because of the negation, but seems right. I'll do a sanity check on ...
11 years, 1 month ago (2009-10-30 15:33:13 UTC) #3
Lasse Reichstein
The code seems completely generic except for the name of the push and jmp operations. ...
11 years, 1 month ago (2009-10-30 18:29:29 UTC) #4
William Hesse
Sanity check
11 years, 1 month ago (2009-11-02 10:08:54 UTC) #5
Kevin Millikin (Chromium)
11 years, 1 month ago (2009-11-02 10:16:13 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld 408576698