Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 343054: Fix tab and button tooltips being truncated with ellipsis. (Closed)

Created:
11 years, 1 month ago by Simon Radford
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Fix tab and button tooltips being truncated with ellipsis. Tooltips were shortened to 1/4 the width of the screen. We do not currently word-wrap, so these tooltips were truncated. This meant that you could not see the full title of some webpages. Worse, the tooltips for the Back and Forward buttons were truncated in some languages. This change increases the max tooltip width to almost the width of the screen. An even better solution would be to word-wrap the text onto multiple lines, but that requires more sweeping changes to the TooltipManagers. R=sky BUG=25522, 22840 TEST=Load a webpage with a very long title (eg. Google search for something super long), and mouse over the tab to get a tooltip displaying the webpage title. If long enough, it should stretch across the whole screen (minus a few pixels), and then end with an ellipsis. No tab or button tooltips should be truncated unless they reach screen width. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M views/widget/tooltip_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Simon Radford
11 years, 1 month ago (2009-10-30 03:33:29 UTC) #1
sky
11 years, 1 month ago (2009-10-30 15:42:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698