Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2177)

Unified Diff: base/process_util_win.cc

Issue 343053: Remove some histograms that have not provided benefit.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_win.cc
===================================================================
--- base/process_util_win.cc (revision 30662)
+++ base/process_util_win.cc (working copy)
@@ -363,34 +363,6 @@
}
// All other exit codes indicate crashes.
-
- // TODO(jar): Remove histogramming code when UMA stats are consistent with
- // other crash metrics.
- // Histogram the low order 3 nibbles for UMA
- const int kLeastValue = 0;
- const int kMaxValue = 0xFFF;
- const int kBucketCount = kMaxValue - kLeastValue + 1;
- static LinearHistogram least_significant_histogram("ExitCodes.LSNibbles",
- kLeastValue + 1, kMaxValue, kBucketCount);
- least_significant_histogram.SetFlags(kUmaTargetedHistogramFlag |
- LinearHistogram::kHexRangePrintingFlag);
- least_significant_histogram.Add(exitcode & 0xFFF);
-
- // Histogram the high order 3 nibbles
- static LinearHistogram most_significant_histogram("ExitCodes.MSNibbles",
- kLeastValue + 1, kMaxValue, kBucketCount);
- most_significant_histogram.SetFlags(kUmaTargetedHistogramFlag |
- LinearHistogram::kHexRangePrintingFlag);
- // Avoid passing in negative numbers by shifting data into low end of dword.
- most_significant_histogram.Add((exitcode >> 20) & 0xFFF);
-
- // Histogram the middle order 2 nibbles
- static LinearHistogram mid_significant_histogram("ExitCodes.MidNibbles",
- 1, 0xFF, 0x100);
- mid_significant_histogram.SetFlags(kUmaTargetedHistogramFlag |
- LinearHistogram::kHexRangePrintingFlag);
- mid_significant_histogram.Add((exitcode >> 12) & 0xFF);
-
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698