Issue 343052: Improve error messages in extensions/docs/build.py .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343052: Improve error messages in extensions/docs/build.py . (Closed)

Created:
11 years, 1 month ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Improve error message in the extension api docs build script. When the json file used to build the html documentation is unreadable or has a syntax error, gives a clear error message. BUG=18717 TEST=Manualy tested a missing input file and a file with a syntax error. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30620

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	MM	chrome/common/extensions/docs/build/build.py	View	1	1 chunk	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Kerner (Chrome)

Rafael, I know this is not quite what issue 18717 asks for. I added it ...

11 years, 1 month ago (2009-10-30 02:28:51 UTC) #1

rafaelw

11 years, 1 month ago (2009-10-30 18:12:07 UTC) #2

lgtm. thanks for doing this. it's fine to have this attached to this bug, just
don't mark it fixed when this commits.

Expand Messages | Collapse Messages