Issue 343051: Make sure we can still navigate to URLs when the History DB can't be loaded....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343051: Make sure we can still navigate to URLs when the History DB can't be loaded.... (Closed)

Created:
11 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make sure we can still navigate to URLs when the History DB can't be loaded. BUG=25822 TEST=Make your History files non-readable, run Chrome (Release), Type in "test.com" and see that the selected action is navigation.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
	M	chrome/browser/autocomplete/history_url_provider.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	chrome/browser/autocomplete/history_url_provider.cc	View		3 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

11 years, 1 month ago (2009-10-30 21:07:32 UTC) #3

On 2009/10/30 15:40:53, sky wrote:
> Would be nice to have a test covering this.

I agree.  I've written one; due to some changelist overlap in my checkout I'll
put it up as a separate review (for brettw).

Expand Messages | Collapse Messages