Issue 343050: Based on the rest of the codebase, I think we're supposed to #include chromiu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343050: Based on the rest of the codebase, I think we're supposed to #include chromiu... (Closed)

Created:
11 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Based on the rest of the codebase, I think we're supposed to #include chromium_strings rather than google_chrome_strings, although I doubt it would matter. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30546

Patch Set 1 #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	chrome/browser/gtk/browser_window_gtk.cc	View	2 chunks	+6 lines, -4 lines	2 comments	Download
M	chrome/browser/gtk/first_run_bubble.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/gtk/first_run_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. It doesn't actually matter because both grd files have the same identifiers in the ...

11 years, 1 month ago (2009-10-30 01:08:54 UTC) #2

Peter Kasting

11 years, 1 month ago (2009-10-30 01:13:36 UTC) #3

http://codereview.chromium.org/343050/diff/1/4
File chrome/browser/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/343050/diff/1/4#newcode1539
Line 1539: // Do not allow the user to resize us arbitrarily small. When using
the
On 2009/10/30 01:08:54, tony wrote:
> Is this supposed to be in the diff?

No, artifact of some file copying locally.  Fixed, will check in.

Expand Messages | Collapse Messages