Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 343040: Fix transparent windowless plugin background painting. This would manifest... (Closed)

Created:
11 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam, ben+cc_chromium.org
Visibility:
Public.

Description

Fix transparent windowless plugin background painting. This would manifest itself as incorrect ClearType edges. The problem was that we were taking into account the translation from the page coordinate system when blitting the background, but this had already been accounted for in the transformation matrix, resulting in duplicate transformations. The fix simplifies the code by not tranlating into the page coordinate system until later, staying in the plugin coordinate system which is more convenient. This means that the background (which is the same size as the buffer) can just be painted at (0,0) with no fuss and no muss. We don't even need to worry about how much we paint since the clip was already installed. This also corrects some indenting in browser.cc that I noticed. TEST="Attach a file" text in Gmail compose looks weird (sometimes requires selecting it to make this happen). BUG=26080 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30498

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/browser.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 chunk +18 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
11 years, 1 month ago (2009-10-29 16:51:25 UTC) #1
jam
11 years, 1 month ago (2009-10-29 17:39:04 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698