Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: build/build-bisect.py

Issue 343029: Bisect script should exit gracefully when not enough revisions are present... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/build-bisect.py
===================================================================
--- build/build-bisect.py (revision 30403)
+++ build/build-bisect.py (working copy)
@@ -145,7 +145,7 @@
print("Just answer the question...")
def main():
- usage = ('%prog [options]\n'
+ usage = ('%prog [options] [-- chromium-options]\n'
'Perform binary search on the snapshot builds.')
parser = optparse.OptionParser(usage=usage)
# Strangely, the default help output doesn't include the choice list.
@@ -206,6 +206,9 @@
# Get a list of revisions to bisect across.
revlist = GetRevList(good_rev, bad_rev)
+ if len(revlist) < 2: # Don't have enough builds to bisect
+ print "We don't have enough builds to bisect. revlist: %s" % revlist
+ sys.exit(1)
# If we don't have a |good_rev|, set it to be the first revision possible.
if good_rev == 0:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698