Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.mm

Issue 343024: Cleans up our autorelease handling so that we don't create a layered ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host_view_mac.mm
===================================================================
--- chrome/browser/renderer_host/render_widget_host_view_mac.mm (revision 30592)
+++ chrome/browser/renderer_host/render_widget_host_view_mac.mm (working copy)
@@ -289,11 +289,6 @@
[subview renderWidgetHostViewMac]->ShutdownHost();
}
- // We've been told to destroy.
- [cocoa_view_ retain];
- [cocoa_view_ removeFromSuperview];
- [cocoa_view_ autorelease];
-
// We get this call just before |render_widget_host_| deletes
// itself. But we are owned by |cocoa_view_|, which may be retained
// by some other code. Examples are TabContentsViewMac's
@@ -544,7 +539,7 @@
if (ignoreKeyEvents_)
return NO;
- // We have some magic in |CrApplication sendEvent:| that always sends key
+ // We have some magic in |CrApplication sendEvent:| that always sends key
// events to |keyEvent:| so that cocoa doesn't have a chance to intercept it.
DCHECK([[self window] firstResponder] != self);
return NO;
« base/message_pump_mac.mm ('K') | « chrome/browser/cocoa/browser_window_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698