Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: chrome/browser/tab_restore_uitest.cc

Issue 343018: Changes ui proxy classes to use Browser::Types rather than copying... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/sessions/session_restore_uitest.cc ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #if defined(OS_WIN) 8 #if defined(OS_WIN)
9 #include "base/win_util.h" 9 #include "base/win_util.h"
10 #endif 10 #endif
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 ASSERT_TRUE(new_tab.get()); 219 ASSERT_TRUE(new_tab.get());
220 // Make sure we're at url. 220 // Make sure we're at url.
221 new_tab->NavigateToURL(url1_); 221 new_tab->NavigateToURL(url1_);
222 // Close the tab. 222 // Close the tab.
223 new_tab->Close(true); 223 new_tab->Close(true);
224 new_tab = NULL; 224 new_tab = NULL;
225 ASSERT_TRUE(browser_proxy->GetTabCount(&tab_count)); 225 ASSERT_TRUE(browser_proxy->GetTabCount(&tab_count));
226 EXPECT_EQ(starting_tab_count + 2, tab_count); 226 EXPECT_EQ(starting_tab_count + 2, tab_count);
227 227
228 // Create a new browser. 228 // Create a new browser.
229 ASSERT_TRUE(automation()->OpenNewBrowserWindow(BrowserProxy::TYPE_NORMAL, 229 ASSERT_TRUE(automation()->OpenNewBrowserWindow(Browser::TYPE_NORMAL, false));
230 false));
231 int window_count; 230 int window_count;
232 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count)); 231 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
233 EXPECT_EQ(2, window_count); 232 EXPECT_EQ(2, window_count);
234 233
235 CheckActiveWindow(automation()->GetBrowserWindow(1)); 234 CheckActiveWindow(automation()->GetBrowserWindow(1));
236 235
237 // Restore tab into original browser. 236 // Restore tab into original browser.
238 RestoreTab(0, closed_tab_index); 237 RestoreTab(0, closed_tab_index);
239 238
240 // And make sure everything looks right. 239 // And make sure everything looks right.
(...skipping 21 matching lines...) Expand all
262 ASSERT_TRUE(browser_proxy->GetTabCount(&tab_count)); 261 ASSERT_TRUE(browser_proxy->GetTabCount(&tab_count));
263 } 262 }
264 263
265 // Navigate to url1 then url2. 264 // Navigate to url1 then url2.
266 scoped_refptr<TabProxy> tab_proxy(browser_proxy->GetTab(0)); 265 scoped_refptr<TabProxy> tab_proxy(browser_proxy->GetTab(0));
267 ASSERT_TRUE(tab_proxy.get()); 266 ASSERT_TRUE(tab_proxy.get());
268 tab_proxy->NavigateToURL(url1_); 267 tab_proxy->NavigateToURL(url1_);
269 tab_proxy->NavigateToURL(url2_); 268 tab_proxy->NavigateToURL(url2_);
270 269
271 // Create a new browser. 270 // Create a new browser.
272 ASSERT_TRUE(automation()->OpenNewBrowserWindow(BrowserProxy::TYPE_NORMAL, 271 ASSERT_TRUE(automation()->OpenNewBrowserWindow(Browser::TYPE_NORMAL, false));
273 false));
274 int window_count; 272 int window_count;
275 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count)); 273 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
276 EXPECT_EQ(2, window_count); 274 EXPECT_EQ(2, window_count);
277 CheckActiveWindow(automation()->GetBrowserWindow(1)); 275 CheckActiveWindow(automation()->GetBrowserWindow(1));
278 276
279 // Close the final tab in the first browser. 277 // Close the final tab in the first browser.
280 EXPECT_TRUE(tab_proxy->Close(true)); 278 EXPECT_TRUE(tab_proxy->Close(true));
281 ASSERT_TRUE(automation()->WaitForWindowCountToBecome( 279 ASSERT_TRUE(automation()->WaitForWindowCountToBecome(
282 1, action_max_timeout_ms())); 280 1, action_max_timeout_ms()));
283 281
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 ASSERT_TRUE(new_tab.get()); 351 ASSERT_TRUE(new_tab.get());
354 // Make sure we're at url. 352 // Make sure we're at url.
355 new_tab->NavigateToURL(url1_); 353 new_tab->NavigateToURL(url1_);
356 // Close the tab. 354 // Close the tab.
357 new_tab->Close(true); 355 new_tab->Close(true);
358 new_tab = NULL; 356 new_tab = NULL;
359 ASSERT_TRUE(browser_proxy->GetTabCount(&tab_count)); 357 ASSERT_TRUE(browser_proxy->GetTabCount(&tab_count));
360 EXPECT_EQ(starting_tab_count + 2, tab_count); 358 EXPECT_EQ(starting_tab_count + 2, tab_count);
361 359
362 // Create a new browser. 360 // Create a new browser.
363 ASSERT_TRUE(automation()->OpenNewBrowserWindow(BrowserProxy::TYPE_NORMAL, 361 ASSERT_TRUE(automation()->OpenNewBrowserWindow(Browser::TYPE_NORMAL, false));
364 false));
365 int window_count; 362 int window_count;
366 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count)); 363 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
367 EXPECT_EQ(2, window_count); 364 EXPECT_EQ(2, window_count);
368 CheckActiveWindow(automation()->GetBrowserWindow(1)); 365 CheckActiveWindow(automation()->GetBrowserWindow(1));
369 366
370 // Close the first browser. 367 // Close the first browser.
371 bool application_closing; 368 bool application_closing;
372 EXPECT_TRUE(CloseBrowser(browser_proxy.get(), &application_closing)); 369 EXPECT_TRUE(CloseBrowser(browser_proxy.get(), &application_closing));
373 EXPECT_FALSE(application_closing); 370 EXPECT_FALSE(application_closing);
374 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count)); 371 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
(...skipping 27 matching lines...) Expand all
402 int starting_tab_count; 399 int starting_tab_count;
403 ASSERT_TRUE(browser_proxy->GetTabCount(&starting_tab_count)); 400 ASSERT_TRUE(browser_proxy->GetTabCount(&starting_tab_count));
404 int tab_count = AddSomeTabs(browser_proxy.get(), 2); 401 int tab_count = AddSomeTabs(browser_proxy.get(), 2);
405 402
406 // Navigate the rightmost one to url2_ for easier identification. 403 // Navigate the rightmost one to url2_ for easier identification.
407 scoped_refptr<TabProxy> tab_proxy(browser_proxy->GetTab(tab_count - 1)); 404 scoped_refptr<TabProxy> tab_proxy(browser_proxy->GetTab(tab_count - 1));
408 ASSERT_TRUE(tab_proxy.get()); 405 ASSERT_TRUE(tab_proxy.get());
409 tab_proxy->NavigateToURL(url2_); 406 tab_proxy->NavigateToURL(url2_);
410 407
411 // Create a new browser. 408 // Create a new browser.
412 ASSERT_TRUE(automation()->OpenNewBrowserWindow(BrowserProxy::TYPE_NORMAL, 409 ASSERT_TRUE(automation()->OpenNewBrowserWindow(Browser::TYPE_NORMAL, false));
413 false));
414 int window_count; 410 int window_count;
415 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count)); 411 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
416 EXPECT_EQ(2, window_count); 412 EXPECT_EQ(2, window_count);
417 CheckActiveWindow(automation()->GetBrowserWindow(1)); 413 CheckActiveWindow(automation()->GetBrowserWindow(1));
418 414
419 // Close all but one tab in the first browser, left to right. 415 // Close all but one tab in the first browser, left to right.
420 while (tab_count > 1) { 416 while (tab_count > 1) {
421 scoped_refptr<TabProxy> tab_to_close(browser_proxy->GetTab(0)); 417 scoped_refptr<TabProxy> tab_to_close(browser_proxy->GetTab(0));
422 ASSERT_TRUE(tab_to_close.get()); 418 ASSERT_TRUE(tab_to_close.get());
423 tab_to_close->Close(true); 419 tab_to_close->Close(true);
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 // page ID of the renderer should have been updated when we restored the tab. 541 // page ID of the renderer should have been updated when we restored the tab.
546 tab->NavigateToURL(http_url2); 542 tab->NavigateToURL(http_url2);
547 EXPECT_FALSE(tab->GoForward()); 543 EXPECT_FALSE(tab->GoForward());
548 EXPECT_EQ(http_url2, GetActiveTabURL()); 544 EXPECT_EQ(http_url2, GetActiveTabURL());
549 } 545 }
550 546
551 TEST_F(TabRestoreUITest, RestoreWindow) { 547 TEST_F(TabRestoreUITest, RestoreWindow) {
552 // Create a new window. 548 // Create a new window.
553 int window_count; 549 int window_count;
554 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count)); 550 ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
555 ASSERT_TRUE(automation()->OpenNewBrowserWindow(BrowserProxy::TYPE_NORMAL, 551 ASSERT_TRUE(automation()->OpenNewBrowserWindow(Browser::TYPE_NORMAL, false));
556 false));
557 int new_window_count = 0; 552 int new_window_count = 0;
558 ASSERT_TRUE(automation()->GetBrowserWindowCount(&new_window_count)); 553 ASSERT_TRUE(automation()->GetBrowserWindowCount(&new_window_count));
559 EXPECT_EQ(++window_count, new_window_count); 554 EXPECT_EQ(++window_count, new_window_count);
560 555
561 // Create two more tabs, one with url1, the other url2. 556 // Create two more tabs, one with url1, the other url2.
562 scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0)); 557 scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));
563 int initial_tab_count; 558 int initial_tab_count;
564 ASSERT_TRUE(browser_proxy->GetTabCount(&initial_tab_count)); 559 ASSERT_TRUE(browser_proxy->GetTabCount(&initial_tab_count));
565 browser_proxy->AppendTab(url1_); 560 browser_proxy->AppendTab(url1_);
566 ASSERT_TRUE(browser_proxy->WaitForTabCountToBecome(initial_tab_count + 1, 561 ASSERT_TRUE(browser_proxy->WaitForTabCountToBecome(initial_tab_count + 1,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 GURL url; 595 GURL url;
601 ASSERT_TRUE(restored_tab_proxy->GetCurrentURL(&url)); 596 ASSERT_TRUE(restored_tab_proxy->GetCurrentURL(&url));
602 EXPECT_TRUE(url == url1_); 597 EXPECT_TRUE(url == url1_);
603 598
604 restored_tab_proxy = browser_proxy->GetTab(initial_tab_count + 1); 599 restored_tab_proxy = browser_proxy->GetTab(initial_tab_count + 1);
605 ASSERT_TRUE(restored_tab_proxy.get()); 600 ASSERT_TRUE(restored_tab_proxy.get());
606 ASSERT_TRUE(restored_tab_proxy->WaitForTabToBeRestored(action_timeout_ms())); 601 ASSERT_TRUE(restored_tab_proxy->WaitForTabToBeRestored(action_timeout_ms()));
607 ASSERT_TRUE(restored_tab_proxy->GetCurrentURL(&url)); 602 ASSERT_TRUE(restored_tab_proxy->GetCurrentURL(&url));
608 EXPECT_TRUE(url == url2_); 603 EXPECT_TRUE(url == url2_);
609 } 604 }
OLDNEW
« no previous file with comments | « chrome/browser/sessions/session_restore_uitest.cc ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698