Issue 343013: With the change in the constructor for the ChromeThread class, we are seeing ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343013: With the change in the constructor for the ChromeThread class, we are seeing ... (Closed)

Created:
11 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews_googlegroups.com, darin (slow to review), amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

With the change in the constructor for the ChromeThread class, we are seeing a DCHECK fire in the Chrome frame network tests for whether the current thread is the UI thread. We need to invoke the correct constructor. The other fix is in our com_util::IDispatchImpl class where we end up crashing if we fail to find the type information for the passed in interface. Strangely this is failing for the IChromeFrame interface which is an IDispatch derivative and seems to be correctly registered. It also fails with the ATL IDispatchImpl classes though. However we should not crash here :) I also removed the NOTREACHED as it keeps firing on debug test runs. Will take a look at this closely later. TBR=tommi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30333

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	MM	chrome_frame/com_type_info_holder.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome_frame/test/net/fake_external_tab.cc	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Issue 343013: With the change in the constructor for the ChromeThread class, we are seeing ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Messages