chrome/test/data/extensions/samples/gmail_browser_action/manifest.json - Issue 343003: Get rid of FilePath::AppendAndResolveRelative()....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/samples/gmail_browser_action/manifest.json

Issue 343003: Get rid of FilePath::AppendAndResolveRelative().... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 {	1 {

2 "name": "Gmail Checker 2",	2 "name": "Gmail Checker 2",

3 "description": "This extension adds a Gmail button to the toolbar which notifi es when new email comes",	3 "description": "This extension adds a Gmail button to the toolbar which notifi es when new email comes",

4 "version": "1.0",	4 "version": "1.0",

5 "background_page": "background.html",	5 "background_page": "background.html",

6 "permissions": [	6 "permissions": [

7 "tabs", "http://.google.com/", "https://.google.com/"	7 "tabs", "http://.google.com/", "https://.google.com/"

8 ],	8 ],

9 "browser_action": {	9 "browser_action": {

10 "default_title": ""	10 "default_title": ""

11 },

12 "icons": {

13 "128": "icon_128.png"
Mark Mentovai 2009/10/28 00:20:48 What's up here, does this not exist? What's up here, does this not exist? MAD 2009/10/28 03:44:45 Yep, I cleaned it up as I tried it and it failed b Show quoted text On 2009/10/28 00:20:48, Mark Mentovai wrote: > What's up here, does this not exist? Yep, I cleaned it up as I tried it and it failed because the icon has been removed from the repo, but the manifest file wasn't updated... I double checked with Aaron :-) Aaron Boodman 2009/10/28 06:08:18 I've since added this file. Please undo this delet Show quoted text On 2009/10/28 03:44:45, mad1 wrote: > On 2009/10/28 00:20:48, Mark Mentovai wrote: > > What's up here, does this not exist? > > Yep, I cleaned it up as I tried it and it failed because the icon has been > removed from the repo, but the manifest file wasn't updated... I double checked > with Aaron :-) I've since added this file. Please undo this delete. MAD 2009/10/28 12:40:54 Done. Show quoted text On 2009/10/28 06:08:18, Aaron Boodman wrote: > On 2009/10/28 03:44:45, mad1 wrote: > > On 2009/10/28 00:20:48, Mark Mentovai wrote: > > > What's up here, does this not exist? > > > > Yep, I cleaned it up as I tried it and it failed because the icon has been > > removed from the repo, but the manifest file wasn't updated... I double > checked > > with Aaron :-) > > I've since added this file. Please undo this delete. Done.
14 }	11 }

15 }	12 }

OLD	NEW

« no previous file with comments | « chrome/common/extensions/extension_resource_unittest.cc ('k') | no next file » | no next file with comments »