Added printing of a couple of links to documentation in case warnings are rep...

tools/valgrind/valgrind_test.py

Index: tools/valgrind/valgrind_test.py
===================================================================
--- tools/valgrind/valgrind_test.py	(revision 30177)
+++ tools/valgrind/valgrind_test.py	(working copy)
@@ -366,7 +366,11 @@
     use_gdb = (sys.platform == 'darwin')
     analyzer = memcheck_analyze.MemcheckAnalyze(self._source_dir, filenames, self._options.show_all_leaks,
                                                 use_gdb=use_gdb)
-    return analyzer.Report()
+    ret = analyzer.Report()
+    if ret != 0:
+      logging.info("Please see http://dev.chromium.org/developers/how-tos/"
+                   "using-valgrind for the info on Memcheck/Valgrind")
+    return ret

[stuartmorgan, 2009/10/27 20:28:27]

The return value is non-zero if there are leaks or invalid reads; why do we need
to tell people how to use valgrind if it's run correctly but finds problems?

 
 class ThreadSanitizer(ValgrindTool):
   """ThreadSanitizer"""
@@ -436,7 +440,12 @@
     use_gdb = (sys.platform == 'darwin')
     analyzer = tsan_analyze.TsanAnalyze(self._source_dir, filenames,
                                         use_gdb=use_gdb)
-    return analyzer.Report()
+    ret = analyzer.Report()
+    if ret != 0:
+      logging.info("Please see http://dev.chromium.org/developers/how-tos/"
+                   "using-valgrind/threadsanitizer for the info on "
+                   "ThreadSanitizer")
+    return ret
 
 
 class ToolFactory:
@@ -445,7 +454,9 @@
       return Memcheck()
     if tool_name == "tsan":
       if sys.platform != 'linux2':
-        logging.info("WARNING: ThreadSanitizer is not working yet on Mac")
+        logging.info("WARNING: ThreadSanitizer may be unstable on Mac.")
+        logging.info("See http://code.google.com/p/data-race-test/wiki/"
+                     "ThreadSanitizerOnMacOsx for the details")
       return ThreadSanitizer()
     raise RuntimeError, "Unknown tool" \
                         "(tool=%s, platform=%s)" % \