Issue 3429029: Wait for renaming chrome.exe to finish during shutdown for...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3429029: Wait for renaming chrome.exe to finish during shutdown for... (Closed)

Created:
10 years, 2 months ago by huanr

Modified:
9 years ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Wait for renaming chrome.exe to finish during shutdown for system level in use update. Also remove obsoleted code in this code path. BUG=55969 TEST=repro steps in BUG Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60751

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -14 lines)			Patch
	M	chrome/browser/first_run/first_run_win.cc	View		2 chunks	+2 lines, -14 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm but see my comment http://codereview.chromium.org/3429029/diff/4001/5001 File chrome/browser/first_run/first_run_win.cc (left): http://codereview.chromium.org/3429029/diff/4001/5001#oldcode303 chrome/browser/first_run/first_run_win.cc:303: if (!GetBackupChromeFile(&backup_exe)) are you ...

10 years, 2 months ago (2010-09-28 01:16:21 UTC) #2

huanr

10 years, 2 months ago (2010-09-28 04:37:26 UTC) #3

On 2010/09/28 01:16:21, cpu wrote:
> lgtm but see my comment
> 
> http://codereview.chromium.org/3429029/diff/4001/5001
> File chrome/browser/first_run/first_run_win.cc (left):
> 
> http://codereview.chromium.org/3429029/diff/4001/5001#oldcode303
> chrome/browser/first_run/first_run_win.cc:303: if
> (!GetBackupChromeFile(&backup_exe))
> are you sure we want to remove this fallback?
> 
> I don't see the harm of that being there.

We already tried to rename ourself by launching setup before calling google
update. And this code is obsolete. It only tries to rename chrome.exe without
deleting opv key.

Expand Messages | Collapse Messages