Issue 3429028: DOMUI: Fix a typo that caused a text to be shown as 'undefined'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3429028: DOMUI: Fix a typo that caused a text to be shown as 'undefined'. (Closed)

Created:
10 years, 2 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
PhistucK, Evan Stade

CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org, jochen (gone - plz use gerrit)

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

DOMUI: Fix a typo that caused a text to be shown as 'undefined'. BUG=53624 TEST=out/Debug/chrome --enable-tabbed-options, Options > Under the hood > Content Settings > Javascript, you should see "Do not allow any site to run Javascript", instead of 'undefined'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60745

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/content_settings.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

PhistucK

On 2010/09/27 02:07:54, tfarina wrote: > I believe you should change the word "Images" in ...

10 years, 2 months ago (2010-09-27 07:54:37 UTC) #3

lgtm

Expand Messages | Collapse Messages