Update scripts for vm's

Update scripts for vm's

Change-Id: I63bdcaa3630c179d407310f6544c102f5353fa4d

BUG=5530
TEST=Ran both cros_run_vm_test and new script and had the latter update successfully.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cc09f84

[sosa, 2010-09-18 01:10:23]

I had to add an option "full" for image_to_vm so that I can create both Root A
and Root B, etc and a larger stateful partition to correctly update an image.

[adlr, 2010-09-20 18:24:43]

http://codereview.chromium.org/3427011/diff/3001/4004
File image_to_vm.sh (right):

http://codereview.chromium.org/3427011/diff/3001/4004#newcode16
image_to_vm.sh:16: assert_inside_chroot
this has historically failed inside the chroot b/c it requires qemu tools to be
installed. Can you generate vmware/qemu/etc images all within the chroot?

http://codereview.chromium.org/3427011/diff/3001/4004#newcode73
image_to_vm.sh:73: ( [[ ${FLAGS_vdisk_size} < 6072 ]] || \
can you use variables for these magic numbers, both here and in the message
below?

[sosa, 2010-09-21 22:20:12]

Adding petkov. 

Have addressed comments, PTAL

http://codereview.chromium.org/3427011/diff/3001/4004
File image_to_vm.sh (right):

http://codereview.chromium.org/3427011/diff/3001/4004#newcode16
image_to_vm.sh:16: assert_inside_chroot
I built using the default options and this just wouldn't work outside the
chroot.  I'll take another look and see if I can fix the issues.

I figured since I couldn't get it to work with default options outside the
chroot, that it was just an oversight.  I'll look more into the issue and see
what I come up with.

On 2010/09/20 18:24:44, adlr wrote:
> this has historically failed inside the chroot b/c it requires qemu tools to
be
> installed. Can you generate vmware/qemu/etc images all within the chroot?

http://codereview.chromium.org/3427011/diff/3001/4004#newcode73
image_to_vm.sh:73: ( [[ ${FLAGS_vdisk_size} < 6072 ]] || \
On 2010/09/20 18:24:44, adlr wrote:
> can you use variables for these magic numbers, both here and in the message
> below? Agreed.

[petkov, 2010-09-21 23:07:01]

LGTM assuming you've confirmed everything works OK inside chroot.

[sosa, 2010-09-22 00:07:06]

As a side note, format vmware is broken.

This was true before this change.  cros_make_image_bootable cannot be run from
outside the chroot (restart_in_chroot is not compatible with that script) and
qemu-img is not in the chroot.

Issue http://code.google.com/p/chromium-os/issues/detail?id=6916 filed.  Since
I'm not breaking anything I don't think that should block this from going in.

[petkov, 2010-09-22 00:08:35]

LGTM assuming you're making things monotonically better :)

[adlr, 2010-09-22 16:45:33]

On Tue, Sep 21, 2010 at 5:08 PM, <petkov@chromium.org> wrote:

> LGTM assuming you're making things monotonically better :)


+1

LGTM


>
>
>
> http://codereview.chromium.org/3427011/show
>