Issue 3427008: autotest: Simplify desktopui_WindowManagerHotkeys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3427008: autotest: Simplify desktopui_WindowManagerHotkeys. (Closed)

Created:
10 years, 3 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, Daniel Erat, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

autotest: Simplify desktopui_WindowManagerHotkeys. This test was broken, probably as a result of the crosh stuff that added an extra step to get to a bash shell. Since that doesn't seem particularly useful to test anyway, I've removed it and changed the logic that we use to verify that the xterm window is focused. I've also removed the volume key stuff that would've run later in the test, since I think it's also obsolete now (the test was checking the ALSA volume level, but I believe that Chrome has been modified to use PulseAudio instead). Change-Id: Ia623ae087fe77b56c40cbde6e0b6e8397e58e931 BUG=chromium-os:3098 TEST=ran it. it fails with "Timed out waiting for logout" after all of the test-specific code has passed, but I'm pretty sure that that's just happening because I'm booting off of a slow USB stick (the logout completes soon after the timeout)

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -82 lines)			Patch
	M	client/site_tests/desktopui_WindowManagerHotkeys/control	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	client/site_tests/desktopui_WindowManagerHotkeys/desktopui_WindowManagerHotkeys.py	View		2 chunks	+3 lines, -80 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages