Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 3426008: Show RegExp calls in the profile. (Closed)

Created:
10 years, 3 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Show RegExp calls in the profile. It turns out they were filtered out. But when I unfiltered them, I discovered another issue: when DevTools run, regexp literals get recompiled each time they called (looks like this is concerned with switching to full compiler), so I ended up having multiple entries for the same regexp. To fix this, I changed the way of how code entries equivalence is considered. BUG=crbug/55999 TEST=cctest/test-profile-generator/ProfileNodeFindOrAddChildForSameFunction (the test isn't for the whole issue, but rather for equivalence testing) Committed: http://code.google.com/p/v8/source/detail?r=5492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/cpu-profiler-inl.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/profile-generator.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M src/profile-generator-inl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
10 years, 3 months ago (2010-09-17 16:45:08 UTC) #1
Søren Thygesen Gjesse
LGTM Could there be times where the same function(source wise) being recompiled should be different ...
10 years, 3 months ago (2010-09-20 06:34:19 UTC) #2
mnaganov (inactive)
10 years, 3 months ago (2010-09-20 09:24:38 UTC) #3
On 2010/09/20 06:34:19, Søren Gjesse wrote:
> LGTM
>

Thanks!
 
> Could there be times where the same function(source wise) being recompiled
> should be different functions? e.g. after page reload?

Surely that's possible. But I think this is a lesser issue than reporting the
same regexp multiple times.

Powered by Google App Engine
This is Rietveld 408576698