Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 3425021: Switched the cloud print proxy to use the Google push notifications.... (Closed)

Created:
10 years, 3 months ago by sanjeevr
Modified:
9 years, 7 months ago
Reviewers:
Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Switched the cloud print proxy to use the Google push notifications. BUG=None TEST=Test notifications with the cloud print proxy. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60682

Patch Set 1 #

Patch Set 2 : Lint fix #

Patch Set 3 : Removed unwanted header #

Patch Set 4 : Some comment changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M chrome/service/cloud_print/cloud_print_consts.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_consts.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 2 3 5 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sanjeevr
10 years, 2 months ago (2010-09-27 16:50:50 UTC) #1
Scott Byer
10 years, 2 months ago (2010-09-27 17:27:26 UTC) #2
LGTM

On 2010/09/27 16:50:50, sanjeevr wrote:
>

Powered by Google App Engine
This is Rietveld 408576698