Issue 3424002: Allow List::sort, with an integer comparison function, to sort 64-bit pointer...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3424002: Allow List::sort, with an integer comparison function, to sort 64-bit pointer... (Closed)

Created:
10 years, 3 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Allow List::sort, with an integer comparison function, to sort 64-bit pointers in profile-generator. Change a static const int member to be declared and defined only inside the class declaration in class Runtime. Committed: http://code.google.com/p/v8/source/detail?r=5453

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	src/profile-generator.cc	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download
	M	src/runtime.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

LGTM with a comment. Thanks, Bill! http://codereview.chromium.org/3424002/diff/3001/4002 File src/runtime.cc (left): http://codereview.chromium.org/3424002/diff/3001/4002#oldcode10109 src/runtime.cc:10109: const int Runtime::kNotFound; ...

10 years, 3 months ago (2010-09-14 15:08:33 UTC) #2

William Hesse

Fixed a problem in the proposed fix. http://codereview.chromium.org/3424002/diff/3001/4002 File src/runtime.cc (left): http://codereview.chromium.org/3424002/diff/3001/4002#oldcode10109 src/runtime.cc:10109: const int ...

10 years, 3 months ago (2010-09-14 15:13:06 UTC) #3

mnaganov (inactive)

10 years, 3 months ago (2010-09-14 15:13:36 UTC) #4

Still LGTM

On 2010/09/14 15:13:06, William Hesse wrote:
> Fixed a problem in the proposed fix.
> 
> http://codereview.chromium.org/3424002/diff/3001/4002
> File src/runtime.cc (left):
> 
> http://codereview.chromium.org/3424002/diff/3001/4002#oldcode10109
> src/runtime.cc:10109: const int Runtime::kNotFound;
> On 2010/09/14 15:08:33, Michail Naganov wrote:
> > Is this change intended for this CL?
> Yes, it fixes a bug just introduced in my commit a few minutes ago.

Expand Messages | Collapse Messages