Issue 6637: remove implicit dependency on unpack_partition.sh from mod_image_for_dev_recovery.sh

Issue 6637: remove implicit dependency on unpack_partition.sh from mod_image_for_dev_recovery.sh

Change-Id: Ibc260c442f6219c000560f7d665d36543c936611

BUG=chromium-os:6637
TEST=manually created a developer recovery image and tested on agz device with developer switch ON that payload image was installed onto the device successfully and the device is able to boot from HD upon completion of recovery process

[Tan Gao, 2010-09-17 22:24:14]

Hi Andrew/Gaurav,

This CL removes the dependency on unpack_partitions.sh from
mod_image_for_dev_recovery.sh. The original issue was uncovered during
preliminary field test. I've made a new dev recovery image and will update test
details when they come along.

PTAL thx!
Tan

[adlr, 2010-09-17 23:53:23]

http://codereview.chromium.org/3423014/diff/2001/3
File mod_image_for_dev_recovery.sh (right):

http://codereview.chromium.org/3423014/diff/2001/3#newcode107
mod_image_for_dev_recovery.sh:107: TEMP_IMG=$(mktemp)
make this a local and have it be echoed at the end of this function

http://codereview.chromium.org/3423014/diff/2001/3#newcode124
mod_image_for_dev_recovery.sh:124: 
rm -rf "${temp_pmbr}"

http://codereview.chromium.org/3423014/diff/2001/3#newcode143
mod_image_for_dev_recovery.sh:143: TEMP_STATE=$(mktemp)
local temp_state=...

also, remove the file at some point

http://codereview.chromium.org/3423014/diff/2001/3#newcode157
mod_image_for_dev_recovery.sh:157: "${TEMP_MNT_STATE}/dev_payload"
indent

http://codereview.chromium.org/3423014/diff/2001/3#newcode163
mod_image_for_dev_recovery.sh:163: update_partition_table
local temp_img=$(update_partition_table)

http://codereview.chromium.org/3423014/diff/2001/3#newcode166
mod_image_for_dev_recovery.sh:166: trap - EXIT
after this, echo "${temp_img}"

http://codereview.chromium.org/3423014/diff/2001/3#newcode173
mod_image_for_dev_recovery.sh:173: create_dev_recovery_image
TEMP_IMG=$(create_dev_recovery_image)

[Tan Gao, 2010-09-20 16:46:51]

http://codereview.chromium.org/3423014/diff/2001/3
File mod_image_for_dev_recovery.sh (right):

http://codereview.chromium.org/3423014/diff/2001/3#newcode107
mod_image_for_dev_recovery.sh:107: TEMP_IMG=$(mktemp)
Done.

http://codereview.chromium.org/3423014/diff/2001/3#newcode124
mod_image_for_dev_recovery.sh:124: 
On 2010/09/17 23:53:23, adlr wrote:
> rm -rf "${temp_pmbr}"

Done.

http://codereview.chromium.org/3423014/diff/2001/3#newcode143
mod_image_for_dev_recovery.sh:143: TEMP_STATE=$(mktemp)
On 2010/09/17 23:53:23, adlr wrote:
> local temp_state=...
> 
> also, remove the file at some point

Done.

http://codereview.chromium.org/3423014/diff/2001/3#newcode157
mod_image_for_dev_recovery.sh:157: "${TEMP_MNT_STATE}/dev_payload"
On 2010/09/17 23:53:23, adlr wrote:
> indent

Done.

http://codereview.chromium.org/3423014/diff/2001/3#newcode163
mod_image_for_dev_recovery.sh:163: update_partition_table
On 2010/09/17 23:53:23, adlr wrote:
> local temp_img=$(update_partition_table)

Done.

http://codereview.chromium.org/3423014/diff/2001/3#newcode166
mod_image_for_dev_recovery.sh:166: trap - EXIT
On 2010/09/17 23:53:23, adlr wrote:
> after this, echo "${temp_img}"

Done.

http://codereview.chromium.org/3423014/diff/2001/3#newcode173
mod_image_for_dev_recovery.sh:173: create_dev_recovery_image
On 2010/09/17 23:53:23, adlr wrote:
> TEMP_IMG=$(create_dev_recovery_image)

Done.

[adlr, 2010-09-20 17:57:12]

LGTM if you retested after these most recent changes.

[gauravsh, 2010-09-20 19:21:17]

lgtm with nits

http://codereview.chromium.org/3423014/diff/5002/6001
File mod_image_for_dev_recovery.sh (right):

http://codereview.chromium.org/3423014/diff/5002/6001#newcode77
mod_image_for_dev_recovery.sh:77: # Due to this resize, we need to created a new
partition table and a new image.
s/created/create/

http://codereview.chromium.org/3423014/diff/5002/6001#newcode170
mod_image_for_dev_recovery.sh:170: sudo umount "${TEMP_MNT_STATE}"
umount -d or you won't free up the loop device

http://codereview.chromium.org/3423014/diff/5002/6001#newcode172
mod_image_for_dev_recovery.sh:172: rm -rf "${temp_state}"
you don't need the -r here

[Tan Gao, 2010-09-20 20:08:01]

http://codereview.chromium.org/3423014/diff/5002/6001
File mod_image_for_dev_recovery.sh (right):

http://codereview.chromium.org/3423014/diff/5002/6001#newcode77
mod_image_for_dev_recovery.sh:77: # Due to this resize, we need to created a new
partition table and a new image.
On 2010/09/20 19:21:17, gauravsh wrote:
> s/created/create/

Done.

http://codereview.chromium.org/3423014/diff/5002/6001#newcode170
mod_image_for_dev_recovery.sh:170: sudo umount "${TEMP_MNT_STATE}"
added cleanup_loop_dev method below

On 2010/09/20 19:21:17, gauravsh wrote:
> umount -d or you won't free up the loop device

http://codereview.chromium.org/3423014/diff/5002/6001#newcode172
mod_image_for_dev_recovery.sh:172: rm -rf "${temp_state}"
On 2010/09/20 19:21:17, gauravsh wrote:
> you don't need the -r here

Done.