Issue 3422005: run_remote_tests: add quote marks around argument passing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3422005: run_remote_tests: add quote marks around argument passing (Closed)

Created:
10 years, 3 months ago by zbehan

Modified:
9 years, 7 months ago

Reviewers:
asharif1, kmixter1

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

run_remote_tests: add quote marks around argument passing * stops the second-pass parsing of arguments into IFS-delimited elements which unbreaks things like --args='-n 10' Change-Id: If8424b5fc06e6dd5a935421a76539e7e91006c37 BUG= TEST=run it and see the argument being passed correctly

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	run_remote_tests.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asharif1

On 2010/09/15 23:18:16, zbehan wrote: > Cool. Thanks for debugging/fixing this. LGTM.

10 years, 3 months ago (2010-09-15 23:32:25 UTC) #2

kmixter1

10 years, 3 months ago (2010-09-15 23:37:23 UTC) #3

LGTM

On Wed, Sep 15, 2010 at 4:32 PM,  <asharif@chromium.org> wrote:
> On 2010/09/15 23:18:16, zbehan wrote:
>
>
> Cool. Thanks for debugging/fixing this.
>
> LGTM.
>
> http://codereview.chromium.org/3422005/show
>

Expand Messages | Collapse Messages