Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: tools/checkbins/checkbins.py

Issue 342115: Temporarily make checkbins.py print debugging information.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Makes sure that all EXE and DLL files in the provided directory were built 6 """Makes sure that all EXE and DLL files in the provided directory were built
7 correctly. 7 correctly.
8 8
9 Currently this tool will check that binaries were built with /NXCOMPAT and 9 Currently this tool will check that binaries were built with /NXCOMPAT and
10 /DYNAMICBASE set. 10 /DYNAMICBASE set.
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 success = False 53 success = False
54 print "Checking %s for /NXCOMPAT... FAIL" % path 54 print "Checking %s for /NXCOMPAT... FAIL" % path
55 55
56 if not success: 56 if not success:
57 # TODO(scherkus): change this back to 1 once I've fixed failing builds. 57 # TODO(scherkus): change this back to 1 once I've fixed failing builds.
58 sys.exit(0) 58 sys.exit(0)
59 59
60 if __name__ == '__main__': 60 if __name__ == '__main__':
61 usage = "Usage: %prog [options] DIRECTORY" 61 usage = "Usage: %prog [options] DIRECTORY"
62 option_parser = optparse.OptionParser(usage=usage) 62 option_parser = optparse.OptionParser(usage=usage)
63
64 # TODO(scherkus): change the default back to False once I've verified this
65 # tool actually does something on the bots.
63 option_parser.add_option("-v", "--verbose", action="store_true", 66 option_parser.add_option("-v", "--verbose", action="store_true",
64 default=False, help="Print debug logging") 67 default=True, help="Print debug logging")
65 options, args = option_parser.parse_args() 68 options, args = option_parser.parse_args()
66 if not args: 69 if not args:
67 option_parser.print_help() 70 option_parser.print_help()
68 sys.exit(0) 71 sys.exit(0)
69 main(options, args) 72 main(options, args)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698