Send an EVENT_SYSTEM_ALERT when a user first places focus within an infobar.

Send an EVENT_SYSTEM_ALERT when a user first places focus within an infobar.
TEST=use Jaws and NVDA to verify that alert gets read when focus enters the infobar.
BUG=37360
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60672

[David Tseng, 2010-09-24 22:04:08]

This adds the logic to send the alert event whenever focus first lands within
the infobar.

Note that we still have to figure out how to order the close button at the end
of the announcement.  The close button lives in the root infobar class while the
label lives in the alert infobar subclass.

[Chris Guillory, 2010-09-24 22:12:29]

LGTM. One comment about adding a comment. Dominic mentioned that there might be
a problem with making this stateless but if it works lets get it in and we can
investigate problems.

http://codereview.chromium.org/3421033/diff/1/2
File chrome/browser/views/infobars/infobars.cc (right):

http://codereview.chromium.org/3421033/diff/1/2#newcode191
chrome/browser/views/infobars/infobars.cc:191: if (focused_before && focused_now
&&
Add a comment here. Mention that this is for JAWS.

[David Tseng, 2010-09-24 22:35:47]

On 9/24/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
> LGTM. One comment about adding a comment. Dominic mentioned that there
> might be
> a problem with making this stateless but if it works lets get it in and we
> can
> investigate problems.
>
>
> http://codereview.chromium.org/3421033/diff/1/2
> File chrome/browser/views/infobars/infobars.cc (right):
>
> http://codereview.chromium.org/3421033/diff/1/2#newcode191
> chrome/browser/views/infobars/infobars.cc:191: if (focused_before &&
> focused_now &&
> Add a comment here. Mention that this is for JAWS.
Done.

I haven't been able to trigger all the various types of infobars, so
issues may or may not crop up.

[dmazzoni, 2010-09-24 22:39:31]

Yes, sometimes the focus will change from View A to NULL, and from NULL to
View B. So if View A and View B are both within the same infobar, this would
end up being too verbose.

Probably best to keep track of the last non-NULL view or a bool whether the
focus was previously in the InfoBar.

Otherwise LGTM.

- Dominic

On Fri, Sep 24, 2010 at 3:35 PM, David Tseng <dtseng@chromium.org> wrote:

> On 9/24/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
> > LGTM. One comment about adding a comment. Dominic mentioned that there
> > might be
> > a problem with making this stateless but if it works lets get it in and
> we
> > can
> > investigate problems.
> >
> >
> > http://codereview.chromium.org/3421033/diff/1/2
> > File chrome/browser/views/infobars/infobars.cc (right):
> >
> > http://codereview.chromium.org/3421033/diff/1/2#newcode191
> > chrome/browser/views/infobars/infobars.cc:191: if (focused_before &&
> > focused_now &&
> > Add a comment here. Mention that this is for JAWS.
> Done.
>
> I haven't been able to trigger all the various types of infobars, so
> issues may or may not crop up.
>