Issue 342103: Make bookmark folder look Mac-y

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342103: Make bookmark folder look Mac-y (Closed)

Created:
11 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make bookmark folder look Mac-y BUG=http://crbug.com/26457 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30849

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/cocoa/bookmark_bar_controller.mm	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Faster to just fix than schedule. This was still marked as a beta blocker, so ...

11 years, 1 month ago (2009-11-03 19:26:20 UTC) #1

Nico

Heh, I'm currently building with [[[NSWorkspace sharedWorkspace] iconForFileType:@"fold"] :-) But your version looks even nicer. ...

11 years, 1 month ago (2009-11-03 19:33:00 UTC) #2

Avi (use Gerrit)

11 years, 1 month ago (2009-11-03 19:35:53 UTC) #3

On 2009/11/03 19:33:00, Nico wrote:
> In that case, we should just bundle the bitmap and
> load it from the resource bundle. But I think that's unlikely)

We can't bundle the bitmap. One, it's not ours, and two, it's changed in the
past and likely to change again.

Expand Messages | Collapse Messages