Issue 3421025: cros_make_image_bootable is not compatible with restart_inside_chroot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3421025: cros_make_image_bootable is not compatible with restart_inside_chroot (Closed)

Created:
10 years, 3 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

cros_make_image_bootable is not compatible with restart_inside_chroot restart_inside_chroot first assumes that the calling script is in src/scripts. Next any paths are not converted when passed so if someone passes the most recent image, this will also not be interpreted correctly. Change-Id: Icb2dfc661eb84e134b4d8c5cf0354a6c1ab161f0 BUG= TEST=Manually tested running outside chroot (getting error) and inside chroot. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e8c3cdc

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	bin/cros_make_image_bootable	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

restart_inside_chroot is misleading as this won't work. A caller script must run this with ./enter_chroot ...

10 years, 3 months ago (2010-09-22 00:16:29 UTC) #1

LGTM

Expand Messages | Collapse Messages