Add --ignore-externals to svn update and svn checkout invocations.

Add --ignore-externals to svn update and svn checkout invocations.

svn:externals are slow to update and are unnecessary in a gclient environment.

TEST=none
BUG=55904
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71604

[bradn, 2010-09-16 22:16:26]

So I'm using externals for the boto library that gets pulled in by gsutil.
I suppose we could switch that to using DEPS, what's prompting this?

[M-A Ruel, 2010-09-20 19:59:24]

On 2010/09/16 22:16:26, bradn wrote:
> So I'm using externals for the boto library that gets pulled in by gsutil.
> I suppose we could switch that to using DEPS, what's prompting this?

It is slow and causes us to fetch stuff we don't need.

[bradn, 2010-09-20 21:25:53]

You mean specifically the boto library?
I need it on a range of slaves. Its like 460K total, has it been stalling
somewhere?

-BradN

On Mon, Sep 20, 2010 at 12:59 PM, <maruel@chromium.org> wrote:

> On 2010/09/16 22:16:26, bradn wrote:
>
>> So I'm using externals for the boto library that gets pulled in by gsutil.
>> I suppose we could switch that to using DEPS, what's prompting this?
>>
>
> It is slow and causes us to fetch stuff we don't need.
>
>
> http://codereview.chromium.org/3421013/show
>

[M-A Ruel, 2010-09-22 17:23:46]

On 2010/09/20 21:25:53, bradn wrote:
> You mean specifically the boto library?

No, I mean breakpad and protobuf2 pulls in unneeded stuff.

[M-A Ruel, 2010-09-24 18:33:58]

On 2010/09/22 17:23:46, Marc-Antoine Ruel wrote:
> On 2010/09/20 21:25:53, bradn wrote:
> > You mean specifically the boto library?
> 
> No, I mean breakpad and protobuf2 pulls in unneeded stuff.

That does mean you'll have to change the DEPS that fetches gsutil. (Where?)

[M-A Ruel, 2010-09-24 18:56:12]

Nicolas, what do you think?

[Nicolas Sylvain, 2010-09-26 16:56:07]

On Fri, Sep 24, 2010 at 11:56 AM, <maruel@chromium.org> wrote:

> Nicolas, what do you think?


I think that :

1. externals are sad
2. we should have had this ignore flag at the beginning
3. this will make it a little bit harder to roll the gsutil deps, but i'm
not too worried about this
4. Are you sure this won't break anything else?  I thought we had the mock
thing doing an external and the code it was getting was needed too... maybe
not?

either way, if it works, then i think I agree with the change.

>
>
> http://codereview.chromium.org/3421013/show
>

[M-A Ruel, 2011-01-17 20:00:26]

Time to clean up old patches.

I've updated the patch to also delete svn:external's during a gclient revert for
consistency.

Since the tree is mostly idle today, I'll commit this patch and verify it still
builds on the try slaves. By removing the external directories, the try server
will make sure that this change won't silently break full checkout.

[M-A Ruel, 2011-01-18 22:10:12]

On 2011/01/17 20:00:26, Marc-Antoine Ruel wrote:
> Time to clean up old patches.
> 
> I've updated the patch to also delete svn:external's during a gclient revert
for
> consistency.
> 
> Since the tree is mostly idle today, I'll commit this patch and verify it
still
> builds on the try slaves. By removing the external directories, the try server
> will make sure that this change won't silently break full checkout.

Nothing blew up, I'm shocked.