Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 3421011: Import error library into site_wifitest (Closed)

Created:
10 years, 3 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Import error library into site_wifitest site_wifitest.py has historically used error.TestFail exceptions without actually importing this class. This means whenever there's a TestFail, we get an exception saying "error" doesn't exit, instead of the root cause. BUG=none TEST=ReRun run_remote_tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M server/site_wifitest.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 3 months ago (2010-09-15 23:56:57 UTC) #1
Sam Leffler
10 years, 3 months ago (2010-09-16 22:34:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698