Issue 342094: Valgrind: try to remove a suppression for V8 Profiler::Engage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342094: Valgrind: try to remove a suppression for V8 Profiler::Engage. (Closed)

Created:
11 years, 1 month ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Valgrind: try to remove a suppression for V8 Profiler::Engage. Profiler log saver is now not engaged until profiling is really started, which should never happen in currently valgdrinded tests. Let's see if it's true. BUG=24503 TEST=linux valgrind should not complain about the stack deleted from suppressions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30808

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages