Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 342093: DevTools: fix renderer crash when pause is pressed during page load (Closed)

Created:
11 years, 1 month ago by yurys
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

DevTools: fix renderer crash when pause is pressed during page load Create an empty object template for the utility context global object instead of using ShadowObjectTemplate. The shadow object overrides some of the window properties(top, location,...) that led to a failure when accessing these properties since the template was not configured correctly(all its internal fields were undefined). In fact, we don't need the utility context global object to be a shadow object as long as inspected window global object is proto of the utility context global object. BUG=26058 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M webkit/glue/devtools/debugger_agent_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
Here is the fix. I'm trying to figure out how to write a test for ...
11 years, 1 month ago (2009-11-03 08:09:59 UTC) #1
yurys
11 years, 1 month ago (2009-11-03 10:26:21 UTC) #2
mnaganov (inactive)
11 years, 1 month ago (2009-11-03 10:28:01 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698