Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 342073: Refactor the somewhat complicated code generation for assignments into... (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Refactor the somewhat complicated code generation for assignments into a platform-independent structure and a few platform-specific helpers to do the heavy lifting. Committed: http://code.google.com/p/v8/source/detail?r=3195

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -338 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 2 chunks +68 lines, -110 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +27 lines, -9 lines 0 comments Download
M src/fast-codegen.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/fast-codegen.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 1 chunk +67 lines, -110 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 1 chunk +67 lines, -109 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 1 month ago (2009-10-31 20:09:40 UTC) #1
fschneider
11 years, 1 month ago (2009-11-02 10:33:38 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698