Linux: Re-enable omnibox select-all-on-click for Chrome OS builds.

Linux: Re-enable omnibox select-all-on-click for Chrome OS builds.

TEST=built chrome-os and non- binaries and made sure they worked as expected

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30667

[Daniel Erat, 2009-10-30 23:17:10]

http://codereview.chromium.org/342069/diff/4/1003
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/342069/diff/4/1003#newcode197
Line 197: g_signal_connect(text_view_, "button-press-event",
I could protect these behind a #if as well if you want, but I'm worried that it
will confuse poor souls who try to add code to the button press and release
handlers for the regular Linux build later without realizing that they're not
connected.

[Evan Martin, 2009-10-31 02:43:35]

http://codereview.chromium.org/342069/diff/4/1003
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/342069/diff/4/1003#newcode197
Line 197: g_signal_connect(text_view_, "button-press-event",
On 2009/10/30 23:17:10, Daniel Erat wrote:
> I could protect these behind a #if as well if you want, but I'm worried that
it
> will confuse poor souls who try to add code to the button press and release
> handlers for the regular Linux build later without realizing that they're not
> connected.

I think it's better to pull them out here.  The #ifdef chromeos around the
function bodies should alert people something's fishy.

[Daniel Erat, 2009-10-31 03:32:34]

On 2009/10/31 02:43:35, Evan Martin wrote:
> http://codereview.chromium.org/342069/diff/4/1003
> File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):
> 
> http://codereview.chromium.org/342069/diff/4/1003#newcode197
> Line 197: g_signal_connect(text_view_, "button-press-event",
> On 2009/10/30 23:17:10, Daniel Erat wrote:
> > I could protect these behind a #if as well if you want, but I'm worried that
> it
> > will confuse poor souls who try to add code to the button press and release
> > handlers for the regular Linux build later without realizing that they're
not
> > connected.
> 
> I think it's better to pull them out here.  The #ifdef chromeos around the
> function bodies should alert people something's fishy.

Thanks, another look?

[Evan Martin, 2009-10-31 06:13:22]

LGTM