Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 342055: Add void operator to fast compiler. (Closed)

Created:
11 years, 1 month ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add void operator to fast compiler. Committed: http://code.google.com/p/v8/source/detail?r=3186

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -6 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M src/fast-codegen.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 2 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
11 years, 1 month ago (2009-10-30 10:10:23 UTC) #1
Kevin Millikin (Chromium)
LGTM. http://codereview.chromium.org/342055/diff/1/2 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/342055/diff/1/2#newcode647 Line 647: void FastCodeGenerator::VisitUnaryOperation(UnaryOperation* node) { Call the parameter ...
11 years, 1 month ago (2009-10-30 10:25:53 UTC) #2
William Hesse
11 years, 1 month ago (2009-10-30 11:27:49 UTC) #3
http://codereview.chromium.org/342055/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/342055/diff/1/2#newcode647
Line 647: void FastCodeGenerator::VisitUnaryOperation(UnaryOperation* node) {
On 2009/10/30 10:25:53, Kevin Millikin wrote:
> Call the parameter 'expr' like all the other ones :)

Done.

http://codereview.chromium.org/342055/diff/1/2#newcode654
Line 654: if (node->context() == Expression::kValue) {
On 2009/10/30 10:25:53, Kevin Millikin wrote:
> You should probably write a switch over node->context() here so that we will
get
> a compiler warning to catch new contexts when they're introduced.

Done.

Powered by Google App Engine
This is Rietveld 408576698