Issue 342048: Show a warning when the history files can't be read correctly....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342048: Show a warning when the history files can't be read correctly.... (Closed)

Created:
11 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Show a warning when the history files can't be read correctly. This re-plumbs the existing "TooNew" codepath to handle arbitrary error messages. BUG=25822 TEST=Make your history files non-readable, run Chrome (Release), make sure you get a warning dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30642

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -37 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_window.h	View	1	1 chunk	+2 lines, -2 lines	1 comment	Download
M	chrome/browser/cocoa/browser_window_cocoa.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/browser_window_cocoa.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/history/history.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history_backend.h	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_backend_unittest.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/history/history_unittest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/test/test_browser_window.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 1 month ago (2009-10-30 21:52:43 UTC) #2

LGTM

http://codereview.chromium.org/342048/diff/4001/4006
File chrome/browser/browser_window.h (right):

http://codereview.chromium.org/342048/diff/4001/4006#newcode208
Line 208: // Shows a dialog to the user that something is wrong with the
profile.
Can you document the parameter here?

Expand Messages | Collapse Messages