Fix for crash when a bookmark URL is an empty string ...

bookmarks/bookmark_storage.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_storage.h"
 
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/histogram.h"
 #include "base/message_loop.h"
@@ skipping 63 matching lines @@
         details_(details) {
   }
 
   virtual void Run() {
     bool bookmark_file_exists = file_util::PathExists(path_);
     if (bookmark_file_exists) {
       JSONFileValueSerializer serializer(path_);
       scoped_ptr<Value> root(serializer.Deserialize(NULL));
 
       if (root.get()) {
-        // Building the index cane take a while, so we do it on the background
+        // Building the index can take a while, so we do it on the background
         // thread.
         int64 max_node_id = 0;
         BookmarkCodec codec;
         TimeTicks start_time = TimeTicks::Now();
         codec.Decode(details_->bb_node(), details_->other_folder_node(),
                      &max_node_id, *root.get());
         details_->set_max_id(std::max(max_node_id, details_->max_id()));
         details_->set_computed_checksum(codec.computed_checksum());
         details_->set_stored_checksum(codec.stored_checksum());
         details_->set_ids_reassigned(codec.ids_reassigned());
@@ skipping 14 matching lines @@
           bookmark_file_exists, path_));
     } else {
       storage_->OnLoadFinished(bookmark_file_exists, path_);
     }
   }
 
  private:
   // Adds node to the model's index, recursing through all children as well.
   void AddBookmarksToIndex(BookmarkNode* node) {
     if (node->is_url()) {
-      details_->index()->Add(node);
+      if (node->GetURL().is_valid())
+        details_->index()->Add(node);
     } else {
       for (int i = 0; i < node->GetChildCount(); ++i)
         AddBookmarksToIndex(node->GetChild(i));
     }
   }
 
   const FilePath path_;
   MessageLoop* loop_;
   scoped_refptr<BookmarkStorage> storage_;
   LoadDetails* details_;
@@ skipping 141 matching lines @@
 }
 
 void BookmarkStorage::RunTaskOnBackendThread(Task* task) const {
   if (backend_thread()) {
     backend_thread()->message_loop()->PostTask(FROM_HERE, task);
   } else {
     task->Run();
     delete task;
   }
 }