Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: third_party/tcmalloc/tcmalloc.gyp

Issue 342041: Taking advantage of new configuration inheritance option.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mini_installer.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/tcmalloc/tcmalloc.gyp
===================================================================
--- third_party/tcmalloc/tcmalloc.gyp (revision 30478)
+++ third_party/tcmalloc/tcmalloc.gyp (working copy)
@@ -16,11 +16,7 @@
],
'direct_dependent_settings': {
'configurations': {
- # TODO(bradnelson): find a way to make this more graceful in gyp.
- # Ideally configurations should be able to have some sort of
- # inheritance hierarchy. So that Purify no-tcmalloc could be
- # be derived from Release.
- 'Debug': {
+ 'Common': {
'msvs_settings': {
'VCLinkerTool': {
'IgnoreDefaultLibraryNames': ['libcmtd.lib', 'libcmt.lib'],
@@ -30,16 +26,6 @@
},
},
},
- 'Release': {
- 'msvs_settings': {
- 'VCLinkerTool': {
- 'IgnoreDefaultLibraryNames': ['libcmtd.lib', 'libcmt.lib'],
- 'AdditionalDependencies': [
- '<(SHARED_INTERMEDIATE_DIR)/tcmalloc/libcmt.lib'
- ],
- },
- },
- },
},
'conditions': [
['OS=="win"', {
« no previous file with comments | « chrome/installer/mini_installer.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698