Enable ExternalProtocolDialog for linux/views

Enable ExternalProtocolDialog for Chromeos.
 * It simply says it's not supported as ChromeOS wont launch external program.
Fixed resource files to use chromeos. Apparently I misunderstood how this works when I added 'toolkit_views' to grd files. It was never defined, and wasn't necessary.

BUG=23853
TEST=type in "apple.cm" in the omnibox and it should popup the external protocol dialog.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30593

[sky, 2009-10-29 22:03:02]

http://codereview.chromium.org/342040/diff/11/1011
File chrome/app/chromium_strings.grd (right):

http://codereview.chromium.org/342040/diff/11/1011#newcode239
Line 239: <if expr="not pp_ifdef('chromeos')">
Can we group all chromeos and not chromeos strings together in resource files. I
think it'll make it clearer.

http://codereview.chromium.org/342040/diff/11/1014
File chrome/browser/chromeos/external_protocol_dialog.cc (right):

http://codereview.chromium.org/342040/diff/11/1014#newcode22
Line 22: const int kMessageWidth = 400;
Shouldn't this be localized?

http://codereview.chromium.org/342040/diff/11/1014#newcode33
Line 33: render_process_host_id, routing_id);
DCHECK(tab_contents)

http://codereview.chromium.org/342040/diff/11/1014#newcode67
Line 67: UMA_HISTOGRAM_LONG_TIMES("clickjacking.launch_url",
Is this applicable to us?

http://codereview.chromium.org/342040/diff/11/1014#newcode90
Line 90: L"",
std::wstring

http://codereview.chromium.org/342040/diff/11/1015
File chrome/browser/chromeos/external_protocol_dialog.h (right):

http://codereview.chromium.org/342040/diff/11/1015#newcode9
Line 9: #include "googleurl/src/gurl.h"
Forward declare gurl.

[oshima, 2009-10-29 23:21:16]

i'll update the change once i figure out how to separate resource files.

http://codereview.chromium.org/342040/diff/11/1011
File chrome/app/chromium_strings.grd (right):

http://codereview.chromium.org/342040/diff/11/1011#newcode239
Line 239: <if expr="not pp_ifdef('chromeos')">
On 2009/10/29 22:03:02, sky wrote:
> Can we group all chromeos and not chromeos strings together in resource files.
I
> think it'll make it clearer.

looking into now.

http://codereview.chromium.org/342040/diff/11/1014
File chrome/browser/chromeos/external_protocol_dialog.cc (right):

http://codereview.chromium.org/342040/diff/11/1014#newcode22
Line 22: const int kMessageWidth = 400;
On 2009/10/29 22:03:02, sky wrote:
> Shouldn't this be localized?

I'm assuming this is good enough as this is Chrome is doing on Windows.

http://codereview.chromium.org/342040/diff/11/1014#newcode33
Line 33: render_process_host_id, routing_id);
On 2009/10/29 22:03:02, sky wrote:
> DCHECK(tab_contents)

Done.

http://codereview.chromium.org/342040/diff/11/1014#newcode67
Line 67: UMA_HISTOGRAM_LONG_TIMES("clickjacking.launch_url",
On 2009/10/29 22:03:02, sky wrote:
> Is this applicable to us?

removed.

http://codereview.chromium.org/342040/diff/11/1014#newcode90
Line 90: L"",
On 2009/10/29 22:03:02, sky wrote:
> std::wstring

Done.

http://codereview.chromium.org/342040/diff/11/1015
File chrome/browser/chromeos/external_protocol_dialog.h (right):

http://codereview.chromium.org/342040/diff/11/1015#newcode9
Line 9: #include "googleurl/src/gurl.h"
On 2009/10/29 22:03:02, sky wrote:
> Forward declare gurl.

Done.

[sky, 2009-10-30 15:38:29]

LGTM