Issue 342039: Disable the -fvisibility=hidden flag for tcmalloc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342039: Disable the -fvisibility=hidden flag for tcmalloc (Closed)

Created:
11 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, willchan no longer on Chromium, Evan Martin

CC:
chromium-reviews_googlegroups.com, not_the_right_glider

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Disable the -fvisibility=hidden flag for tcmalloc This is necessary to fix the crashes of binaries linked with tcmalloc. The patch was prepared by Alexander Potapenko (cc'ed) Originally reviewed as http://codereview.chromium.org/343037 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30479

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	third_party/tcmalloc/tcmalloc.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

willchan no longer on Chromium

11 years, 1 month ago (2009-10-29 18:26:59 UTC) #2

LGTM for reasons stated in 343037.