Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 342033: Make run_webkit_tests work on Windows 7. ... (Closed)

Created:
11 years, 1 month ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Make run_webkit_tests work on Windows 7. We modify test_shell --check-sys-deps to allow Win 7, add a "chromium-win-7" port to platform_utils, a "WIN-7" port to test_expectations, and create an empty shell directory under webkit/data/layout_tests to make the regression scripts happy. The actual new baselines will follow in a separate CL. R=ojan@chromium.org TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30528

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
A webkit/data/layout_tests/platform/chromium-win-7/README.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/layout_package/platform_utils_win.py View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/layout_package/test_expectations.py View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_platform_delegate_win.cc View 1 2 3 2 chunks +13 lines, -7 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
11 years, 1 month ago (2009-10-29 02:48:39 UTC) #1
Dirk Pranke
11 years, 1 month ago (2009-10-29 20:05:57 UTC) #2
ojan
http://codereview.chromium.org/342033/diff/6001/6004 File webkit/tools/test_shell/test_shell_platform_delegate_win.cc (right): http://codereview.chromium.org/342033/diff/6001/6004#newcode64 Line 64: isWin7 = true; This is unused. Don't we ...
11 years, 1 month ago (2009-10-29 20:15:14 UTC) #3
ojan
LGTM http://codereview.chromium.org/342033/diff/6006/7003 File webkit/tools/test_shell/test_shell_platform_delegate_win.cc (right): http://codereview.chromium.org/342033/diff/6006/7003#newcode73 Line 73: ; // XP Nit: This seems weird ...
11 years, 1 month ago (2009-10-29 20:32:31 UTC) #4
Dirk Pranke
11 years, 1 month ago (2009-10-29 21:03:19 UTC) #5
http://codereview.chromium.org/342033/diff/6001/6004
File webkit/tools/test_shell/test_shell_platform_delegate_win.cc (right):

http://codereview.chromium.org/342033/diff/6001/6004#newcode64
Line 64: isWin7 = true;
On 2009/10/29 20:15:14, ojan wrote:
> This is unused. Don't we want to send WIN7 down the isVista path below?

Good catch. Fixed.

http://codereview.chromium.org/342033/diff/6006/7003#newcode73
Line 73: && osvi.wProductType == VER_NT_WORKSTATION) {
On 2009/10/29 20:32:31, ojan wrote:
> Nit: This seems weird to me. That compiles?
> 
> How about instead checking for the following and adding the error in that
case?
> 
> !(osvi.dwMajorVersion == 5
>   && osvi.dwMinorVersion == 1
>   && osvi.wProductType == VER_NT_WORKSTATION)
> 
> 

Sure, it compiles - it's just an empty statement. But your suggestion is better.

Powered by Google App Engine
This is Rietveld 408576698