Issue 342032: Remove the element_ member of FormField, as we don't use it and shouldn't be ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342032: Remove the element_ member of FormField, as we don't use it and shouldn't be ... (Closed)

Created:
11 years, 1 month ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Remove the element_ member of FormField, as we don't use it and shouldn't be using WebCore internals in glue anyway. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30512

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -43 lines)			Patch
M	chrome/browser/webdata/web_database_unittest.cc	View	2	5 chunks	+12 lines, -24 lines	0 comments	Download
M	chrome/common/render_messages.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/form_field.h	View		1 chunk	+1 line, -11 lines	0 comments	Download
M	webkit/glue/form_field.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	webkit/glue/form_field_values.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

LGTM!