Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 342031: Mailto links should not include mailto: when copying to the clipboard.... (Closed)

Created:
11 years, 1 month ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
ericu
CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org
Visibility:
Public.

Description

Mailto links should not include mailto: when copying to the clipboard. BUG=24430 TEST=Right click a mailto:foo@bar.com link on a page, select Copy email address. Make sure the clipboard contains foo@bar.com and no mailto: prefix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/net/browser_url_util.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
Remember the fix for Copy Url (http://crbug.com/13488)? It looks like that CL inadvertently removed some ...
11 years, 1 month ago (2009-10-28 23:05:03 UTC) #1
ericu
LGTM; thanks for the fix.
11 years, 1 month ago (2009-10-29 17:35:26 UTC) #2
ericu
11 years, 1 month ago (2009-10-29 17:36:41 UTC) #3
On 2009/10/29 17:35:26, ericu. wrote:
> LGTM; thanks for the fix.

Trybot needs another run, though; looks like svn choked.

Powered by Google App Engine
This is Rietveld 408576698