Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 342029: Blacklist PDF Browser Plugin on Mac for now (Closed)

Created:
11 years, 1 month ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
Amanda Walker
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Blacklist PDF Browser Plugin on Mac for now. Add more comprehensive whitelist/blacklist logic so that we can easily switch defaults. BUG=24918, 26110 TEST=Install plugin, follow a link to a PDF; you should not get a page with nothing but a crash notification for the plugin. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30535

Patch Set 1 #

Patch Set 2 : full whitelist/blacklist logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -7 lines) Patch
M webkit/glue/plugins/plugin_list_mac.mm View 1 1 chunk +54 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stuartmorgan
We can take another look at this when QuickTime is in better shape and see ...
11 years, 1 month ago (2009-10-28 22:53:52 UTC) #1
Amanda Walker
Rather than blacklist this specific plugin, since we'll want a "real" blacklist or whitelist for ...
11 years, 1 month ago (2009-10-29 00:00:49 UTC) #2
Amanda Walker
As a bonus, the general solution would also knock off http://code.google.com/p/chromium/issues/detail?id=26110 :-).
11 years, 1 month ago (2009-10-29 00:22:11 UTC) #3
stuartmorgan
Added full white/list blacklist logic. This does minimal ifdef'ing--which means a bit of unnecessary runtime ...
11 years, 1 month ago (2009-10-29 23:04:44 UTC) #4
Amanda Walker
11 years, 1 month ago (2009-10-29 23:40:33 UTC) #5
LGTM.  Maybe add a comment that it assumes the lists will be short (and to
change to a binary search if they get big).

Powered by Google App Engine
This is Rietveld 408576698