Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2031)

Unified Diff: chrome/browser/plugin_carbon_interpose_mac.cc

Issue 342026: Fix call ordering in Carbon plugin interposing (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_carbon_interpose_mac.cc
diff --git a/chrome/browser/plugin_carbon_interpose_mac.cc b/chrome/browser/plugin_carbon_interpose_mac.cc
index a7beff7bd14ce92a26264dd986de913791e1e631..e9a4997b93c1662dfb69546fdd480ddbb885a8e7 100644
--- a/chrome/browser/plugin_carbon_interpose_mac.cc
+++ b/chrome/browser/plugin_carbon_interpose_mac.cc
@@ -111,17 +111,19 @@ static void ChromePluginShowWindow(WindowRef window) {
}
static void ChromePluginDisposeWindow(WindowRef window) {
- MaybeReactivateSavedProcess();
- webkit_glue::NotifyBrowserOfPluginDisposeWindow(HIWindowGetCGWindowID(window),
- CGRectForWindow(window));
+ CGWindowID window_id = HIWindowGetCGWindowID(window);
+ CGRect window_rect = CGRectForWindow(window);
DisposeWindow(window);
+ webkit_glue::NotifyBrowserOfPluginDisposeWindow(window_id, window_rect);
+ MaybeReactivateSavedProcess();
}
static void ChromePluginHideWindow(WindowRef window) {
- MaybeReactivateSavedProcess();
- webkit_glue::NotifyBrowserOfPluginHideWindow(HIWindowGetCGWindowID(window),
- CGRectForWindow(window));
+ CGWindowID window_id = HIWindowGetCGWindowID(window);
+ CGRect window_rect = CGRectForWindow(window);
HideWindow(window);
+ webkit_glue::NotifyBrowserOfPluginHideWindow(window_id, window_rect);
+ MaybeReactivateSavedProcess();
}
#pragma mark -
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698