Issue 342026: Fix call ordering in Carbon plugin interposing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342026: Fix call ordering in Carbon plugin interposing (Closed)

Created:
11 years, 1 month ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
Amanda Walker

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix call ordering in Carbon plugin interposing SetSystemUIMode seems to be unhappy with releasing full screen mode while a full-screen plugin window is still frontmont; swap the order of our calls so we do them after the window is closed instead. BUG=25838 TEST=Open a full-screen Flash window, then exit. Dock should re-appear. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30393

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	chrome/browser/plugin_carbon_interpose_mac.cc	View		1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages