Issue 342024: Adds default implementations to WebFrameClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342024: Adds default implementations to WebFrameClient (Closed)

Created:
11 years, 1 month ago by yaar

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Adds default implementations to WebFrameClient http://code.google.com/p/chromium/issues/detail?id=26068 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30516

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -139 lines)
M	webkit/api/public/WebFrameClient.h	View	8 chunks	+48 lines, -44 lines	1 comment
D	webkit/api/src/EmptyWebFrameClientImpl.h	View	1 chunk	+0 lines, -92 lines	0 comments
M	webkit/api/src/WebWorkerImpl.cpp	View	2 chunks	+1 line, -2 lines	0 comments
M	webkit/webkit.gyp	View	1 chunk	+0 lines, -1 line	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 1 month ago (2009-10-29 20:05:44 UTC) #2

LGTM

http://codereview.chromium.org/342024/diff/1/2
File webkit/api/public/WebFrameClient.h (right):

http://codereview.chromium.org/342024/diff/1/2#newcode112
Line 112: WebFrame*, const WebURLError&) { };
nit: kill the trailing ';' here and in other similar places

Expand Messages | Collapse Messages